Re: [Xen-devel] [PATCH 03/20] PVH xen: create domctl_memory_mapping() function

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 15.05.13 at 02:52, Mukesh Rathor <mukesh.rathor@xxxxxxxxxx> wrote:
> @@ -625,67 +689,12 @@ long arch_do_domctl(
>          unsigned long mfn = domctl->u.memory_mapping.first_mfn;
>          unsigned long nr_mfns = domctl->u.memory_mapping.nr_mfns;
>          int add = domctl->u.memory_mapping.add_mapping;
> -        unsigned long i;
> -
> -        ret = -EINVAL;
> -        if ( (mfn + nr_mfns - 1) < mfn || /* wrap? */
> -             ((mfn | (mfn + nr_mfns - 1)) >> (paddr_bits - PAGE_SHIFT)) ||
> -             (gfn + nr_mfns - 1) < gfn ) /* wrap? */
> -            break;
>  
>          ret = -EPERM;
>          if ( !iomem_access_permitted(current->domain, mfn, mfn + nr_mfns - 
> 1) )
>              break;

Removing the checks above will allow the assertion in
rangeset_contains_range() to trigger upon bad input.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel