Re: [Xen-devel] [PATCH V3 1/2] xenbus: save xenstore local status for later use

[Aurelien Chartier <aurelien.chartier@xxxxxxxxxx>]

On 14/05/13 11:17, David Vrabel wrote:
> On 13/05/13 14:13, Aurelien Chartier wrote:
>> Save the xenstore local status computed in xenbus_init. It can then be used
>> later to check if xenstored is running in that domain
>>
>> Signed-off-by: Aurelien Chartier <aurelien.chartier@xxxxxxxxxx>
> Looks straightforward to me.
>
> Reviewed-by: David Vrabel <david.vrabel@xxxxxxxxxx>
>
>> ---
>>  drivers/xen/xenbus/xenbus_comms.h |    1 +
>>  drivers/xen/xenbus/xenbus_probe.c |   27 ++++++++++++---------------
>>  drivers/xen/xenbus/xenbus_probe.h |    7 +++++++
>>  3 files changed, 20 insertions(+), 15 deletions(-)
>>
>> diff --git a/drivers/xen/xenbus/xenbus_comms.h 
>> b/drivers/xen/xenbus/xenbus_comms.h
>> index c8abd3b..be329a1 100644
>> --- a/drivers/xen/xenbus/xenbus_comms.h
>> +++ b/drivers/xen/xenbus/xenbus_comms.h
>> @@ -45,6 +45,7 @@ int xb_wait_for_data_to_read(void);
>>  int xs_input_avail(void);
>>  extern struct xenstore_domain_interface *xen_store_interface;
>>  extern int xen_store_evtchn;
>> +extern enum xenstore_init xen_store_domain;
> This name suggests it's used for a dom ID.  Perhaps xen_store_domain_type?
Indeed, the name is confusing. I will change it for xen_store_domain_type.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel