Re: [Xen-devel] [PATCH V2] .gitignore: Add vim swap files

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2013-05-10 at 19:15 +0100, Andrew Cooper wrote:
> On 10/05/13 19:09, Ian Jackson wrote:
> > Andrew Cooper writes ("Re: [PATCH V2] .gitignore: Add vim swap files"):
> >> On 09/05/13 17:17, Julien Grall wrote:
> >>> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> >>>
> >>> Changes in v2:
> >>>     - update .hgignore
> >> Much appreciated.
> >>
> >> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> > Nacked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> >
> >>> diff --git a/.hgignore b/.hgignore
> >>> index 6b432f7..4bd24fc 100644
> >>> --- a/.hgignore
> >>> +++ b/.hgignore
> >>> @@ -11,6 +11,7 @@
> >>>  .*\.tar\.bz2$
> >>>  .*\.tar\.gz$
> >>>  .*~$
> >>> +.swp$
> > AIUI the format of .hgignore files is lines containing
> > implicitly-^-anchored regexps.
> 
> Nope - the documentation states otherwise
> 
> http://www.selenic.com/mercurial/hgignore.5.html
> 
> "Neither glob nor regexp patterns are rooted. A glob-syntax pattern of
> the form *.c will match a file ending in .c in any directory, and a
> regexp pattern of the form \.c$ will do the same. To root a regexp
> pattern, start it with ^."
> 
> >
> > So this is wrong.  Please copy the (hideous) syntax of the other
> > entries.
> 
> It is wrong because it failes to escape the literal . (which admittedly
> I missed when reviewing it)
> 
> Just because the rest of the .hgignore is wrong doesn't mean new
> additions shouldn't be.

I don't think anything is wrong with the current .hgignore, where the
precise path matters the entries are explicitly anchored with ^ e.g.
^docs/figs/xenserver\.eps$
^docs/html/.*$
^docs/interface/WARNINGS$
etc

Where only the extension or filename matters but not the path it isn't
anchored, like the examples in the context of the patch.

I fixed this is .*\.swp$ as I committed it, which is consistent with the
existing entries even though the ".*" is technically redundant AFAICT.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel