Re: [Xen-devel] [PATCH V3 37/41] xen/arm: Add exynos 4210 UART support

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 05/10/2013 10:49 AM, Ian Campbell wrote:

> On Fri, 2013-05-10 at 03:18 +0100, Julien Grall wrote:
>> From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
>>
>> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
>> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
>> [...]
> 
>> +        if ( status & UINTM_ERROR )
>> +        {
>> +            uint32_t error_bit;
>> +
>> +            error_bit = exynos4210_read(uart, UERSTAT);
>> +
>> +            if ( error_bit & UERSTAT_OVERRUN )
>> +                dprintk(XENLOG_ERR, "uart: overrun error\n");
>> +            if ( error_bit & UERSTAT_PARITY )
>> +                dprintk(XENLOG_ERR, "uart: parity error\n");
>> +            if ( error_bit & UERSTAT_FRAME )
>> +                dprintk(XENLOG_ERR, "uart: frame error\n");
>> +            if ( error_bit & UERSTAT_BREAK )
>> +                dprintk(XENLOG_ERR, "uart: break detected\n");
> 
> I'm curious to know where these dprintk's go ;-), but:

Directly on the UART :/. But I'm not sure if UART errors are fatal or not.

> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>


-- 
Julien

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel