Re: [Xen-devel] [PATCH] docs: make 'gmake dist-docs' work

[Christoph Egger <chegger@xxxxxxxxx>]

On 24.04.13 15:02, Ian Campbell wrote:
> On Wed, 2013-04-24 at 13:54 +0100, Christoph Egger wrote:
>> On 24.04.13 13:48, Ian Campbell wrote:
>>> On Mon, 2013-04-22 at 12:55 +0100, Egger Christoph wrote:
>>>> doc: Makefile fixes
>>>>     
>>>> - use correct pathes (make gmake dist-docs from toplevel directory work)
>>>> - use tools as found by configure (perl)
>>>
>>> Did you test this?
>>
>> Yes.
> 
> Against unstable?

yes.

> 
>> [...]
>>
>>> $(PERL) is defined in config/Tools.mk but docs/Makefile by design only
>>> includes config/Docs.mk. I think you need to check for perl in
>>> docs/configure.ac as well and propagate the result into config/Docs.mk
>>>         AC_ARG_VAR([PERL], [Path to Perl parser])
>>>         AX_PATH_PROG_OR_FAIL([PERL], [perl])
>>
>> docs/Makefile also includes Config.mk which in turn includes
>> config/Tools.mk.
> 
> Not here it doesn't:
>         $ git show --oneline
>         0a97f68 install qemu into the location specified via configure 
> --prefix.
>         ...
>         $ grep Tools.mk Config.mk 
>         $
>         $ grep include Config.mk 
>         -include $(XEN_ROOT)/.config
>         include $(XEN_ROOT)/config/$(XEN_OS).mk
>         include $(XEN_ROOT)/config/$(XEN_TARGET_ARCH).mk
>         EXTRA_INCLUDES += $(EXTRA_PREFIX)/include
>         $
>         $ rgrep -l Tools.mk *
>         tools/config.status
>         tools/Makefile
>         tools/Rules.mk
>         tools/configure.ac
>         tools/config.log
>         tools/configure
> 
> Perhaps you have some other local patches?

Yes. Just submitted with subject
'[Xen-devel] [PATCH] Make sure to use tools as found by configure'.

Christoph


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel