Re: [Xen-devel] [PATCH V3 29/41] xen/arm: Use device tree API in pl011 UART driver

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2013-05-10 at 03:18 +0100, Julien Grall wrote:
> Allow UART driver to retrieve all its information in the device tree.
> It's possible to choose the pl011 driver via the Xen command line.
> 
> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

+static int __init pl011_uart_init(struct dt_device_node *dev,
+                                  const void *data)

... might be worth warning if (char *)data != ""?

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel