Re: [Xen-devel] [PATCH v2] qemu-xen:Correctly expose PCH ISA bridge for IGD passthrough [and 2 more messages]

[Pasi Kärkkäinen <pasik@xxxxxx>]

On Tue, May 07, 2013 at 06:12:30PM +0100, Ian Jackson wrote:
> Stefano Stabellini writes ("Re: [Xen-devel] [PATCH v2] qemu-xen:Correctly 
> expose PCH ISA bridge for IGD passthrough"):
> > On Mon, 25 Feb 2013, Jan Beulich wrote:
> > > >>> On 25.02.13 at 12:24, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> wrote:
> > > > Jan Beulich writes ("Re: [Xen-devel] [PATCH v2] qemu-xen:Correctly 
> > > > expose PCH 
> > > >> Which means that my pointing out of shortcomings in this patch
> > > >> got completely ignored - we can only hope that this won't bite us
> > > >> later...
> > > > 
> > > > Sorry about that, perhaps I didn't spot the thread.  Do you think it
> > > > should be reverted ?
> > > 
> > > I'd prefer if you did so, and wait for a cleaned up version of the
> > > patch to be submitted. If you leave in what's there right now, I
> > > would b afraid that we'd never get to see a fixup patch on top.
> > 
> > You are talking about 5114F15002000078000BD2B2@xxxxxxxxxxxxxxxxxxxx?
> > G.R., can you work on this patch a bit more and address Jan's comments?
> > It shouldn't take long..
> 

So this "PATCH v2" here was posted on 19 Dec 2012. It got applied, 
and then reverted due to Jan's comments/concerns.

"Patch series for IGD passthrough" has a newer version of this patch,
posted on 08 Feb 2013.


> Stefano Stabellini writes ("Re: [Xen-devel] Patch series for IGD 
> passthrough"):
> > On Tue, 16 Apr 2013, George Dunlap wrote:
> > > On Mon, Apr 15, 2013 at 9:48 PM, Pasi Kärkkäinen <pasik@xxxxxx> wrote:
> > > > On Wed, Mar 20, 2013 at 07:17:14PM +0200, Pasi Kärkkäinen wrote:
> > > >> On Fri, Feb 08, 2013 at 12:12:05AM +0800, Rui Guo wrote:
> > > >> > This series contains all the fixes required to produce a working IGD
> > > >> > passthrough box. All the changes are previously seen in the dev list 
> > > >> > but
> > > >> > not yet accepted. Some of them are out-dated and need some reshape.
> > > >> >
> > > >> > Detailed description can be found later in each patch.
> > > >> >
> > > >> > . [PATCH 1/3] qemu-xen-trad/pt_msi_disable: do not clear all MSI 
> > > >> > flags
> > > >> > . [PATCH 2/3] qemu-xen-trad: Correctly expose PCH ISA bridge for IGD
> > > >> > . [PATCH 3/3] qemu-xen-trad: IGD passthrough: Expose vendor specific
> > > >> >
> > > >>
> > > >> Looking at qemu-xen-unstable I think patches 2 and 3 are not yet 
> > > >> applied.
> > > >> (patch 2 was applied earlier but it got reverted).
> > > >>
> > > >> Is it likely that we'll get these merged in for Xen 4.3 ?
> 
> Have you addressed Jan's comments from February ?  I don't see
> anything saying you have done so.
> 

"Patch series for IGD passthrough" has a later version of the patch in question.
I'm not sure if Jan's comments are addressed properly, there's no changelog on 
the patch,
but the patch seems different from the one that got applied+reverted.


> Also please could you CC patches to the maintainer (ie, me, in this
> case) and also to people who have commented on them in the past (Jan,
> in this case).
> 
> Simply constantly pinging is not appropriate.
> 

Sorry for that, but I just wanted to get some attention to these patches,
because it wasn't clear what still needs to be done to get them merged.

All three patches on the "Patch series for IGD passthrough" are ACKed by 
Stefano:
http://lists.xen.org/archives/html/xen-devel/2013-02/msg00593.html


patch 1/3: This one seems to have been merged already to qemu-xen-unstable.
patch 2/3: this one got some comments, but to me it looks like it didn't get a 
NACK? (and it has Stefano's ACK).
patch 3/3: This one might still have un-addressed comments?


Jan: Can you please re-check 2/3 and 3/3 ? 

"[PATCH 2/3] qemu-xen-trad: Correctly expose PCH ISA bridge for IGD 
passthrough":
http://lists.xen.org/archives/html/xen-devel/2013-02/msg00536.html

"[PATCH 3/3] qemu-xen-trad: IGD passthrough: Expose vendor specific pci cap on 
host bridge":
http://lists.xen.org/archives/html/xen-devel/2013-02/msg00538.html


Thanks,

-- Pasi


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel