Re: [Xen-devel] [PATCH] xen/arm: Don't start a QEMU for backend

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Wed, 8 May 2013, Julien Grall wrote:
> /usr/lib/xen/bin/qemu-system-i386 doesn't exist on ARM. We need to check
> if the file exists/is executable and starts it.
> 
> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>

Good idea but we should actually do that only on ARM: we don't want to
hide bad configurations on x86.

You can check for HOSTTYPE or MACHTYPE, not sure which one is better.


>  tools/hotplug/Linux/init.d/xencommons |   11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/hotplug/Linux/init.d/xencommons 
> b/tools/hotplug/Linux/init.d/xencommons
> index a2e633b..bd15bd4 100644
> --- a/tools/hotplug/Linux/init.d/xencommons
> +++ b/tools/hotplug/Linux/init.d/xencommons
> @@ -115,11 +115,14 @@ do_start () {
>       echo Starting xenconsoled...
>       test -z "$XENCONSOLED_TRACE" || XENCONSOLED_ARGS=" 
> --log=$XENCONSOLED_TRACE"
>       ${SBINDIR}/xenconsoled --pid-file=$XENCONSOLED_PIDFILE $XENCONSOLED_ARGS
> -     echo Starting QEMU as disk backend for dom0
>       test -z "$QEMU_XEN" && QEMU_XEN="${LIBEXEC}/qemu-system-i386"
> -     $QEMU_XEN -xen-domid 0 -xen-attach -name dom0 -nographic -M xenpv 
> -daemonize \
> -             -monitor /dev/null -serial /dev/null -parallel /dev/null \
> -             -pidfile $QEMU_PIDFILE
> +     if [ -x "$QEMU_XEN" ]; then
> +             echo Starting QEMU as disk backend for dom0
> +             $QEMU_XEN -xen-domid 0 -xen-attach -name dom0 -nographic \
> +                     -M xenpv -daemonize -monitor /dev/null           \
> +                     -serial /dev/null -parallel /dev/null            \
> +                     -pidfile $QEMU_PIDFILE
> +     fi
>  }
>  do_stop () {
>          echo Stopping xenconsoled
> -- 
> 1.7.10.4
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel