Re: [Xen-devel] [PATCH V2 04/33] xen/arm: Bump early printk internal buffer to 512

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2013-05-08 at 03:33 +0100, Julien Grall wrote:
> When debug is enabled in device tree code, some lines
> are bigger than 80 characters.
> 
> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Although if we can also take steps to not let the line length get too
long that would be valuable, I can see 80-100 being tolerable but if we
are actually seeing lines with 512 characters that is an issue in its
own right. I appreciate you've just picked a "big enough" number and we
hopefully aren't seeing anything like 512 in practice.

> Changes in v2:
>  - Move buffer to a static variable
> ---
>  xen/arch/arm/early_printk.c |    5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/xen/arch/arm/early_printk.c b/xen/arch/arm/early_printk.c
> index bdf4c0e..0f99a43 100644
> --- a/xen/arch/arm/early_printk.c
> +++ b/xen/arch/arm/early_printk.c
> @@ -29,6 +29,9 @@ void __init early_putch(char c)
>      *r = c;
>  }
>  
> +/* Early printk buffer */
> +static char __initdata buf[512];
> +
>  static void __init early_puts(const char *s)
>  {
>      while (*s != '\0') {
> @@ -41,8 +44,6 @@ static void __init early_puts(const char *s)
>  
>  static void __init early_vprintk(const char *fmt, va_list args)
>  {
> -    char buf[80];
> -
>      vsnprintf(buf, sizeof(buf), fmt, args);
>      early_puts(buf);
>  }



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel