Re: [Xen-devel] [PATCH v2 2/2] libvchan: replace munmap with correct xc_gntshr_munmap

[George Dunlap <George.Dunlap@xxxxxxxxxxxxx>]

On Sat, May 4, 2013 at 11:10 PM, Marek Marczykowski
<marmarek@xxxxxxxxxxxxxxxxxxxxxx> wrote:
> On linux it will end up in munmap anyway, but do not assume any
> particular xc_gntshr_munmap implementation details.
>
> Signed-off-by: Marek Marczykowski <marmarek@xxxxxxxxxxxxxxxxxxxxxx>

Hmm, we don't seem to have a maintainer specifically for this code.

Is this fixing an actual bug for you?  The commit message doesn't
mention anything.  If it's just code clean-up, it should probably wait
until the 4.4 development window opens.

 -George

> ---
>  tools/libvchan/io.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/tools/libvchan/io.c b/tools/libvchan/io.c
> index 5ec5fb9..3040099 100644
> --- a/tools/libvchan/io.c
> +++ b/tools/libvchan/io.c
> @@ -324,9 +324,11 @@ void libxenvchan_close(struct libxenvchan *ctrl)
>         if (!ctrl)
>                 return;
>         if (ctrl->read.order >= PAGE_SHIFT)
> -               munmap(ctrl->read.buffer, 1 << ctrl->read.order);
> +               xc_gntshr_munmap(ctrl->gntshr, ctrl->read.buffer,
> +                               1 << (ctrl->read.order - PAGE_SHIFT));
>         if (ctrl->write.order >= PAGE_SHIFT)
> -               munmap(ctrl->write.buffer, 1 << ctrl->write.order);
> +               xc_gntshr_munmap(ctrl->gntshr, ctrl->write.buffer,
> +                               1 << (ctrl->write.order - PAGE_SHIFT));
>         if (ctrl->ring) {
>                 if (ctrl->is_server) {
>                         ctrl->ring->srv_live = 0;
> --
> 1.8.1.4
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel