Re: [Xen-devel] [PATCH] qemu-traditional: update configure check for -lrt changes in glibc 2.17

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2013-05-08 at 10:43 +0100, George Dunlap wrote:
> On Tue, May 7, 2013 at 4:41 PM, Eric Shelton <eshelton@xxxxxxxxx> wrote:
> > On Wed, May 1, 2013 at 09:21:17AM -0700, Matt Wilson wrote:
> >> On Mon, Apr 29, 2013 at 03:40:13PM +0200, Olaf Hering wrote:
> >> > Ping
> >>
> >> Makes sense.
> >>
> >> Acked-by: Matt Wilson <msw@xxxxxxxxxx>
> >>
> >> > On Wed, Jan 16, Olaf Hering wrote:
> >> >
> >> > > Ping
> >> > >
> >> > > On Wed, Dec 05, Olaf Hering wrote:
> >> > >
> >> > > > configure uses clock_gettime to check whether -lrt is needed - and 
> >> > > > don't
> >> > > > check other functions. With glibc 2.17 clock_gettime is part of 
> >> > > > libc, so
> >> > > > use timer_gettime instead, which is in -lrt in old and new versions 
> >> > > > of
> >> > > > glibc.
> >> > > >
> >> > > > Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
> >> > > > ---
> >> > > >  configure | 2 +-
> >> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> >> > > >
> >> > > > diff --git a/configure b/configure
> >> > > > index 904e019..ace3c3e 100755
> >> > > > --- a/configure
> >> > > > +++ b/configure
> >> > > > @@ -1097,7 +1097,7 @@ fi
> >> > > >  cat > $TMPC <<EOF
> >> > > >  #include <signal.h>
> >> > > >  #include <time.h>
> >> > > > -int main(void) { clockid_t id; return clock_gettime(id, NULL); }
> >> > > > +int main(void) { struct itimerspec v; timer_t t; return 
> >> > > > timer_gettime (t, &v); }
> >> > > >  EOF
> >> > > >
> >> > > >  rt=no
> >
> > At least 2 acked patches were not committed to qemu-traditional before
> > the RC1 freeze & tag.
> 
> The important thing is that you need to start CC'ing the maintainer
> (Stefano Stabellini for qemu-traditional, as i understand it) when

Ian Jackson for -trad and Stefano for -upstream.

These are both listed in MAINTAINERS:
QEMU-DM
M:      Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
S:      Supported
T:      git git://xenbits.xen.org/qemu-xen-*.git

QEMU UPSTREAM
M:      Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
S:      Supported
T:      git git://xenbits.xen.org/qemu-upstream-*.git

It's possible that the title of QEMU-DM need clarifying now that we have
two qemus.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel