Re: [Xen-devel] [PATCH v3] libxl: Spice vdagent support for upstream qemu

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, May 07, 2013 at 11:41:25AM +0100, Ian Campbell wrote:
> On Tue, 2013-05-07 at 11:38 +0100, Wei Liu wrote:
> > On Tue, May 07, 2013 at 11:18:43AM +0100, Ian Campbell wrote:
> > [...]
> > > > 
> > > > What I meant is in the documentation we should use true / false instead
> > > > of 1 / 0. Other options use true / false as well, like e820_host and
> > > > spiceagent_mouse.
> > > 
> > > Or right, we do seem to be rather inconsistent about that.
> > > 
> > > Given that the parser (currently) only understands 0 and 1 (or other
> > > integers I guess) I think the most consistent usage would be to write
> > > "true (1)" or "false (0)" everywhere.
> > > 
> > > Do you fancy putting together a patch to make this so?
> > > 
> > 
> > We already have clear definition of BOOLEAN type around line 37 in the same
> > file. IMHO using "true" / "false" is sufficent.
> 
> People never read this stuff properly.
> 
> In any case the current docs use 0/1 and true/false in approximately
> equal measure...
> 

Haha, patch on the way.


Wei.

> Ian.
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel