Re: [Xen-devel] [PATCH] xen-netback: remove dead code

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2013-05-06 at 16:40 +0100, Wei Liu wrote:
> The array mmap_pages is never touched in the initialization function. This is
> remnant of mapping mechanism, which does exist upstream.
                                         ^not

Can you add a quick note about to the changelog about where this array
is now initialised and freed please, with that:

> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Please resubmit when Dave opens net-next for new development.

Ian.

> ---
>  drivers/net/xen-netback/netback.c |    4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/net/xen-netback/netback.c 
> b/drivers/net/xen-netback/netback.c
> index 37984e6..295a9c2 100644
> --- a/drivers/net/xen-netback/netback.c
> +++ b/drivers/net/xen-netback/netback.c
> @@ -1939,10 +1939,6 @@ static int __init netback_init(void)
>  failed_init:
>       while (--group >= 0) {
>               struct xen_netbk *netbk = &xen_netbk[group];
> -             for (i = 0; i < MAX_PENDING_REQS; i++) {
> -                     if (netbk->mmap_pages[i])
> -                             __free_page(netbk->mmap_pages[i]);
> -             }
>               del_timer(&netbk->net_timer);
>               kthread_stop(netbk->task);
>       }



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel