Re: [Xen-devel] [PATCH v3] xen: handle paged gfn in wrmsr_hypervisor_regs

[Olaf Hering <olaf@xxxxxxxxx>]

On Fri, May 03, Jan Beulich wrote:


> Apart from formatting things look okay up to here.

Did you mean just the single tab in svm_msr_write_intercept?

> > --- a/xen/arch/x86/traps.c
> > +++ b/xen/arch/x86/traps.c
> > @@ -634,25 +634,33 @@ int wrmsr_hypervisor_regs(uint32_t idx, 
> >          unsigned long gmfn = val >> 12;
> >          unsigned int idx  = val & 0xfff;
> >          struct page_info *page;
> > +        p2m_type_t t;
> >  
> >          if ( idx > 0 )
> >          {
> >              gdprintk(XENLOG_WARNING,
> >                       "Out of range index %u to MSR %08x\n",
> >                       idx, 0x40000000);
> > -            return 0;
> > +            return -EINVAL;
> 
> But I'd stay away from converting to actual errors both here ...

I sent v4 with the -EINVAL removed.


Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel