Re: [Xen-devel] [PATCH] xen: handle paged gfn in wrmsr_hypervisor_regs

[Olaf Hering <olaf@xxxxxxxxx>]

On Fri, May 03, Jan Beulich wrote:

> >>> On 02.05.13 at 18:24, Olaf Hering <olaf@xxxxxxxxx> wrote:
> > @@ -1682,14 +1682,15 @@ static int svm_msr_write_intercept(unsig
> >          if ( wrmsr_viridian_regs(msr, msr_content) )
> >              break;
> >  
> > -        wrmsr_hypervisor_regs(msr, msr_content);
> > +        ret = wrmsr_hypervisor_regs(msr, msr_content);
> > +        retry = ret == -EAGAIN;
> 
> If you add error handling, don't constrain this to a single error code
> please. For the case here, the easiest would appear to be a switch
> converting to X86EMUL_OKAY, X86EMUL_RETRY, or
> X86EMUL_UNHANDLEABLE. If the function had ways to fail before,
> it would have been a bug anyway to not check the return value.

I just sent v2 of this patch.


Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel