Re: [Xen-devel] [PATCH 5/6] x86/HVM: fix legacy PIC check in pt_update_irq()

[Tim Deegan <tim@xxxxxxx>]

At 14:54 +0100 on 29 Apr (1367247296), Jan Beulich wrote:
> Depending on the IRQ we need to
> - not look at the PIC at all is this is the LAPIC timer (in that case
>   we're dealing with a vector number rather than an IRQ one),
> - not look at the PIC for any non-legacy interrupt,
> - look at the correct PIC for the IRQ (which will always be PIC 2 for
>   the RTC, and possibly also for HPET).
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Reviewed-by: Tim Deegan <tim@xxxxxxx>

> --- a/xen/arch/x86/hvm/vpt.c
> +++ b/xen/arch/x86/hvm/vpt.c
> @@ -311,8 +311,9 @@ int pt_update_irq(struct vcpu *v)
>       * IRR is returned and used to set eoi_exit_bitmap for virtual
>       * interrupt delivery case. Otherwise return -1 to do nothing.  
>       */ 
> -    if ( vlapic_accept_pic_intr(v) &&
> -         (&v->domain->arch.hvm_domain)->vpic[0].int_output )
> +    if ( !is_lapic &&
> +         platform_legacy_irq(irq) && vlapic_accept_pic_intr(v) &&
> +         (&v->domain->arch.hvm_domain)->vpic[irq >> 3].int_output )
>          return -1;
>      else 
>          return pt_irq_vector(earliest_pt, hvm_intsrc_lapic);
> 
> 
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel