Re: [Xen-devel] [PATCH v2] xenstore: create pidfile in init-xenstore-domain

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

Putting back the original CC list which Christoph dropped a few mails
back. Please be careful of this.

On Thu, 2013-04-25 at 10:56 +0100, Ian Campbell wrote:
> On Thu, 2013-04-25 at 10:05 +0100, Egger, Christoph wrote:
> > On 25.04.13 10:51, Ian Campbell wrote:
> > > On Thu, 2013-04-25 at 09:19 +0100, Christoph Egger wrote:
> > >> @@ -29,9 +29,12 @@ endif
> > >>>  
> > >>>  ALL_TARGETS = libxenstore.so libxenstore.a clients xs_tdb_dump 
> > >>> xenstored
> > >>>  
> > >>> +ifeq ($(CONFIG_Linux),y)
> > >>> +ALL_TARGETS += init-xenstore-domain
> > >>> +endif
> > >>> +
> > >>
> > >> Please explain what is Linux-specific?
> > > 
> > > Can you confirm that this file at least builds as is on NetBSD? Was it
> > > built there previously?
> > 
> > No. It was only enabled for stubdom.
> > Building it manually says:
> > <xen/sys/xenbus_dev.h>: No such file or directory.
> 
> OK, so this should be Linux only until that interface is implemented for
> BSD (should probably be in libxc in any case)

With this in mind I have acked + applied this. Christoph's comment about
using sizeof(buf) is a good one but not worth delaying this patch for.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel