Re: [Xen-devel] [PATCH 09/17] PVH xen: create PVH vmcs, and also initialization

[Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>]

On Wed, 24 Apr 2013 08:42:49 +0100
"Jan Beulich" <JBeulich@xxxxxxxx> wrote:

> >>> On 23.04.13 at 23:25, Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>
> >>> wrote:
> 
> > +    guest_pat = MSR_IA32_CR_PAT_RESET;
> > +    __vmwrite(GUEST_PAT, guest_pat);
> 
> What's the point of having the local variable "guest_pat" here?
> 

copy/paste from existing code in construct_vmcs():

        u64 host_pat, guest_pat;

        rdmsrl(MSR_IA32_CR_PAT, host_pat);
        guest_pat = MSR_IA32_CR_PAT_RESET;

        __vmwrite(HOST_PAT, host_pat);
        __vmwrite(GUEST_PAT, guest_pat);


I'll remove it in mine.

thanks
mukesh

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel