Re: [Xen-devel] [PATCH v4 4/4] xl: Improve xl documentation in regards to guest memory management

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2013-04-30 at 13:34 +0100, Daniel Kiper wrote:
> > >   
> > > ========================================================================= 
> > > */
> > > diff --git a/docs/misc/xenstore-paths.markdown 
> > > b/docs/misc/xenstore-paths.markdown
> > > index 535830e..1ac2159 100644
> > > --- a/docs/misc/xenstore-paths.markdown
> > > +++ b/docs/misc/xenstore-paths.markdown
> > > @@ -124,18 +124,24 @@ This protocol is not currently well documented.
> > >
> > >  #### ~/memory/static-max = MEMKB []
> > >
> > > -Specifies a static maximum amount memory which this domain should
> > > -expect to be given. In the absence of in-guest memory hotplug support
> > > -this set on domain boot and is usually the maximum amount of RAM which
> > > -a guest can make use of. See [docs/misc/libxl_memory.txt][LIBXLMEM]
> > > -for a description of how memory is accounted for in toolstacks using
> > > -the libxl library.
> > > +Specifies a static maximum amount of memory which this domain
> > > +should expect to be given. It is usually the maximum amount
> > > +of RAM which a guest can make use of. This value is set on the
> > > +domain boot. If ~/memory/guest-max is set then static maximum
> > > +is ignored by libxl. See [docs/misc/libxl_memory.txt][LIBXLMEM]
> > > +for a description of how the memory is accounted for in toolstacks
> > > +using the libxl library.
> >
> > I'd retain the "and in the absence of in-guest..." stuff here but go on
> > to add a sentence lile "If in-guest memory hotplug is supported, then it
> > will write guest-max (see below).
> >
> > The key point is to describe the behaviour with and without hotplug.
> 
> I think that every new polite guest, with or without memory hotplug,
> should inform about its maximum supported memory size. It means
> that we should not differentiate both cases here.

We can say things like "guests should do foo" but we need to account for
existing guests which don't and for future guests which still don't,
e.g. at the moment all non-Linux guests.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel