Re: [Xen-devel] [RFC 17/29] xen/arm: New callback in uart_driver to get device tree interrupt structure

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2013-04-29 at 18:09 +0100, Julien Grall wrote:
> On 04/29/2013 04:46 PM, Ian Campbell wrote:
> 
> > On Mon, 2013-04-29 at 00:02 +0100, Julien Grall wrote:
> >> The existing function serial_irq doesn't allow to retrieve if the interrupt
> >> is edge or level trigger.
> >>
> >> Use this function to route all serial IRQs to xen.
> > 
> > All of them? At most we want the one Xen is using, don't we?
> 
> My comment is a bit confusing. "all serial IRQs" means all IRQs of UART
> registered via serial_register_uart.
> 
> Currently Xen on Arm can register zero one one UART (com1).

Ah, OK, thanks.

"Use this function to route IRQs for all serial ports which Xen is using
to Xen" ???

> >> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> >>      gic_route_irq(37, 0, 1u << smp_processor_id(), 0xa0);
> > 
> > Did you intend to remove this line?
> 
> Yes, I let this line to avoid to break xen boot on versatile express.

I think I saw it get removed in a later patch dealing with vexpress, so
that's ok.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel