Re: [Xen-devel] [RFC 20/29] xen/arm: Use the device tree to map the address range and IRQ to dom0

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

> @@ -30,6 +31,14 @@ static void __init parse_dom0_mem(const char *s)
>  }
>  custom_param("dom0_mem", parse_dom0_mem);
>  
> +#define DEBUG_DT

Did you mean to leave this on by default? Seems like it might be a bit
verbose? On the otherhand it would be nice to replace the "Map CS2 MMIO
regions 1:1 in the P2M ..." messages with something, and this seems like
it...

> +
> +static int parse_device_tree(struct domain *d)

This is more like map_device_from_device_tree(d).

Both minor nits, so:
Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel