Re: [Xen-devel] [RFC 15/29] xen/arm: Don't hardcode VGIC informations

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2013-04-29 at 00:01 +0100, Julien Grall wrote:
> @@ -754,11 +759,21 @@ void gic_interrupt(struct cpu_user_regs *regs, int 
> is_fiq)
>  
>  int gicv_setup(struct domain *d)
>  {
> +    /* TODO: Retrieve distributor and CPU guest base address from the
> +     * guest DTS
> +     * For the moment we use dom0 DTS

FWIW I think what we will need here eventually is domctl's so the
toolstack can set this stuff explicitly to match the DT it generates,
not to pass the guest DTB to the hypervisor and parse it or anything
like that (maybe that's not what you were suggesting).

>  /* Number of ranks of interrupt registers for a domain */
> @@ -79,7 +77,16 @@ int domain_vgic_init(struct domain *d)
>      int i;
>  
>      d->arch.vgic.ctlr = 0;
> -    d->arch.vgic.nr_lines = 32;
> +
> +    /**

Javadoc? ;-)

Other than those two nits: 
Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> +     * Currently nr_lines in vgic and gic doesn't have the same meanings
> +     * Here nr_lines = number of SPIs
> +     */
> +    if ( d->domain_id == 0 )
> +        d->arch.vgic.nr_lines = gic_number_lines() - 32;
> +    else
> +        d->arch.vgic.nr_lines = 0; /* We don't need SPIs for the guest */
> +


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel