Re: [Xen-devel] [PATCH 2/2] libxl: fix spelling of "backend-id" for vtpm

[Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>]

On 04/29/2013 04:40 AM, Ian Campbell wrote:
> On Sun, 2013-04-28 at 00:17 +0100, Marek Marczykowski wrote:
>
> Adding Daniel. We need to confirm that this doesn't break compatibility
> with existing frontends. If it does then we just have to live with it
> IMHO.
None of the frontends I can find rely on backend_id; in fact, they all rely
on "backend-id" so this is a bug. The code in question is only reading, so
it also couldn't have introduced bad frontend code elsewhere.

> > Signed-off-by: Marek Marczykowski <marmarek@xxxxxxxxxxxxxxxxxxxxxx>
> > ---
> >   tools/libxl/libxl.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
> > index e2c678a..7d0cd10 100644
> > --- a/tools/libxl/libxl.c
> > +++ b/tools/libxl/libxl.c
> > @@ -1855,7 +1855,7 @@ libxl_device_vtpm *libxl_device_vtpm_list(libxl_ctx *ctx, 
> > uint32_t domid, int *n
> >             vtpm->devid = atoi(*dir);
> >
> >             tmp = libxl__xs_read(gc, XBT_NULL,
> > -                GCSPRINTF("%s/%s/backend_id",
> > +                GCSPRINTF("%s/%s/backend-id",
> >                      fe_path, *dir));
> >             vtpm->backend_domid = atoi(tmp);
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel