Re: [Xen-devel] [PATCH v4 04/12] xen/arm: support for guest SGI

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Fri, 26 Apr 2013, Ian Campbell wrote:
> > +
> > +
> > +    for_each_set_bit( vcpuid, &vcpu_mask, d->max_vcpus )
> > +    {
> > +        if ( vcpuid >= d->max_vcpus || (vt = d->vcpu[vcpuid]) == NULL )
> 
> Is d->vcpu[vcpuid] == NULL sufficient here? A vcpu which exists but has
> not been PSCI'd up will pass this -- what do we do to them? Hopefully we
> don't wake them up? Do we not want to check something like _VPF_down
> too?

I think you are right, we should test for _VPF_down too

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel