Re: [Xen-devel] [PATCH 14/17] PVH xen: Add and remove foreign pages

[Tim Deegan <tim@xxxxxxx>]

At 14:26 -0700 on 23 Apr (1366727163), Mukesh Rathor wrote:
> In this patch, a new function, xenmem_add_foreign_to_pmap(), is added
> to map pages from foreign guest into current dom0 for domU creation.
> Also, allow XENMEM_remove_from_physmap to remove p2m_map_foreign
> pages. Note, in this path, we must release the refcount that was taken
> during the map phase.

Much better, thanks!

One comment: 

> +    if ( currd->domain_id == foreign_domid || foreign_domid == DOMID_SELF ||
> +         !is_pvh_domain(currd) )
> +        return -EINVAL;

If you're not going to implement XENMAPSPACE_gmfn_foreign for normal HVM
domains, can you please add a comment to public/memory.h to say that
it's PVH-only on x86. 

Thanks,

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel