Re: [Xen-devel] [PATCH 07/17] PVH xen: tools changes to create PVH domain

[Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>]

On Wed, 24 Apr 2013 08:10:05 +0100
"Jan Beulich" <JBeulich@xxxxxxxx> wrote:

> >>> On 23.04.13 at 23:25, Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>
> >>> wrote:
> > --- a/xen/include/public/domctl.h
> > +++ b/xen/include/public/domctl.h
> > @@ -89,6 +89,9 @@ struct xen_domctl_getdomaininfo {
> >   /* Being debugged.  */
> >  #define _XEN_DOMINF_debugged  6
> >  #define XEN_DOMINF_debugged   (1U<<_XEN_DOMINF_debugged)
> > + /* domain is PVH */
> > +#define _XEN_DOMINF_pvh_guest 7
> > +#define XEN_DOMINF_pvh_guest   (1U<<_XEN_DOMINF_pvh_guest)
> >   /* XEN_DOMINF_shutdown guest-supplied code.  */
> >  #define XEN_DOMINF_shutdownmask 255
> >  #define XEN_DOMINF_shutdownshift 16
> 
> This change cannot logically belong here, but ought to live in the
> hypervisor side one. That's both for easing applying the patch
> eventually (thus needing only a tools side ack) and from a logical
> point of view (the producer of the interface change should exist
> _before_ the consumer).
> 
> Jan
> 

Ok, I'll move this change to patch 6.

thanks,
Mukesh

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel