Re: [Xen-devel] [PATCH] libxl: write IO ABI for disk frontends

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Apr 24, 2013 at 10:24:57AM +0100, Ian Campbell wrote:
> On Wed, 2013-04-24 at 10:08 +0100, Roger Pau Monné wrote:
> > On 23/04/13 22:25, Wei Liu wrote:
> > > +#if defined (__i386__) || (__x86_64__)
> > 
> > I would prefer to get the guest type (x86 or arm) from libxc if possible
> > and use that instead of a define, different compilers tend to have
> > different names for this macros.
> 
> By pushing the logic down into libxc we can put the implementation in
> xc_dom_x86.c and a stub in xc_dom_arm.c and get this behaviour without
> the ifdefs.
> 

xc_dom_*.c is for domain builder, is it really the right place to put
generic domain control / information query functions?

I would prefer creating new files called xc_domain_x86.c and
xc_domain_arm.c.


Wei.

> Ian.
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel