[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 13/28] libxl: idl: add domain_type field to libxl_dominfo struct

  • To: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
  • From: Rob Hoes <Rob.Hoes@xxxxxxxxxx>
  • Date: Tue, 23 Apr 2013 14:27:44 +0100
  • Accept-language: en-US
  • Acceptlanguage: en-US
  • Cc: "xen-devel@xxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxx>
  • Delivery-date: Tue, 23 Apr 2013 13:29:53 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xen.org>
  • Thread-index: Ac5AJXlYmaLvh3KfR3+wHMXYzUqZGwAACYrg
  • Thread-topic: [PATCH 13/28] libxl: idl: add domain_type field to libxl_dominfo struct

> > One reason is simply to report to the user what kind of VMs they have
> > running.
> Does xapi/xenopsd not already track this in the DB?
> >  Xenopsd also uses this information internally in some places, e.g.
> > when inserting a CD, it uses libxl_cdrom_insert for HVMs, and does a
> > normal VBD hotplug for PV.
> xenopsd doesn't already know which to use?

It is probably not strictly necessary, because xenopsd would remember whether 
it has started a VM as PV or HVM. But I think that it is in general just a 
little safer to ask Xen what the state of the system is rather than relying on 
internal state in the daemon.


> I wonder if it is/was a mistake to not have libxl_cdrom_insert do the
> obvious PV thing for PV guests.
> Ian.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.