Re: [Xen-devel] [PATCH] tools/pygrub: do not override pygrub with a symbolic link

[Matt Wilson <msw@xxxxxxxxxx>]

On Mon, Apr 22, 2013 at 04:48:01PM +0200, Christoph Egger wrote:
> 
>     tools/pygrub: Do not override pygrub with a symbolic link if $(BINDIR)
>     and $(PRIVATE_BINDIR) are the same.
>     
>     Signed-off-by: Christoph Egger <chegger@xxxxxxxxx>

This one looks good to me too.

Reviewed-by: Matt Wilson <msw@xxxxxxxxxx>

> diff --git a/tools/pygrub/Makefile b/tools/pygrub/Makefile
> index 039f7f7..0191638 100644
> --- a/tools/pygrub/Makefile
> +++ b/tools/pygrub/Makefile
> @@ -14,7 +14,8 @@ install: all
>               $(PYTHON_PREFIX_ARG) --root="$(DESTDIR)" \
>               --install-scripts=$(PRIVATE_BINDIR) --force
>       $(INSTALL_DIR) $(DESTDIR)/var/run/xend/boot
> -     set -e; if [ "`readlink -f $(DESTDIR)/$(BINDIR)`" != \
> +     set -e; if [ $(BINDIR) != $(PRIVATE_BINDIR) -a \
> +                  "`readlink -f $(DESTDIR)/$(BINDIR)`" != \
>                    "`readlink -f $(PRIVATE_BINDIR)`" ]; then \
>           ln -sf $(PRIVATE_BINDIR)/pygrub $(DESTDIR)/$(BINDIR); \
>       fi
> 
> 
> Christoph
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel