Re: [Xen-devel] [PATCH V2 0/2] xen/arm: implement smp_call_function

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2013-04-16 at 14:38 +0100, Julien Grall wrote:
> This patch series can be applied on top of Ian's patch series "arm: host SMP 
> support"
> 
> The first patch fixes an issue on SMP board when smp_call_function is
> implemented.
> The second patch implements the function.
> 
> Changes since V1:
>   - Move smp_call_function and on_selected_cpus in the common part
>   - Use spin_lock instead of spin_lock_irqsave in patch 1
> 
> Julien Grall (2):
>   xen/arm: gic_disable_cpu must be called with interrupts disabled
>   xen/arm: implement smp_call_function

Keir/Jan do you have any Ack/Nack WRT the code motion from x86 to common
code?

WRT the freeze George said in <516EA78A.9090800@xxxxxxxxxxxxx>:
        
        If Keir or Jan think that if there is a regression we are highly
        likely to catch it before the release, I'm OK with Julien's
        series.

I think smp_call_function is used much more on x86 than on ARM (which
currently only needs it for reboot). On x86 it (or rather the inner
on_selected_cpus function) is used in at least the IRQ, time calibration
and EPT code which ought to give it a reasonable workout under normal
use I think...

> 
>  xen/arch/arm/gic.c            |    9 +++-
>  xen/arch/arm/smp.c            |   11 ++---
>  xen/arch/x86/smp.c            |   88 +++-----------------------------------
>  xen/common/Makefile           |    1 +
>  xen/common/smp.c              |   94 
> +++++++++++++++++++++++++++++++++++++++++
>  xen/include/asm-arm/gic.h     |    1 +
>  xen/include/asm-x86/hardirq.h |    1 +
>  xen/include/xen/smp.h         |    7 +++
>  8 files changed, 120 insertions(+), 92 deletions(-)
>  create mode 100644 xen/common/smp.c
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel