[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] hotplug: add openvswitch script



On Thu, 2013-04-18 at 14:42 +0100, Bastian Blank wrote:
> On Thu, Apr 18, 2013 at 12:50:40PM +0100, Ian Campbell wrote:
> > +    ovs-vsctl --timeout=30 -- --if-exists del-port $dev -- add-port 
> > "$bridge" $dev $tag_arg $trunk_arg $vif_details
> > +        ovs-vsctl --timeout=30 -- --if-exists del-port $dev
> 
> There is some error handling missing. Not sure how to do that correctly.

Possibly should either call fatal on error or use the do_or_die helper?



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.