Re: [Xen-devel] [PATCH] x86/S3: Fix cpu pool scheduling after suspend/resume (v2)

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 17.04.13 at 17:25, Ben Guthro <benjamin.guthro@xxxxxxxxxx> wrote:
> --- a/xen/common/cpupool.c
> +++ b/xen/common/cpupool.c
> @@ -41,7 +41,9 @@ static struct cpupool *alloc_cpupool_struct(void)
>  {
>      struct cpupool *c = xzalloc(struct cpupool);
>  
> -    if ( c && zalloc_cpumask_var(&c->cpu_valid) )
> +    if ( c &&
> +        zalloc_cpumask_var(&c->cpu_suspended) &&
> +        zalloc_cpumask_var(&c->cpu_valid) )
>          return c;
>      xfree(c);
>      return NULL;

You may leak c->cpu_suspended now.

Also, please look out again for use of hard tabs in your additions.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel