Re: [Xen-devel] [PATCH v4 1/2] libxl: Introduce functions to add and remove USB devices to an HVM guest

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

George Dunlap writes ("Re: [PATCH v4 1/2] libxl: Introduce functions to add and 
remove USB devices to an HVM guest"):
> >> +        case LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN:
> >> +            if ( (rc = libxl__qmp_usb_remove(gc, domid, usbdev)) < 0 )
> > Spaces
> 
> How important are the spaces?  Most of the time I think it makes it
> easier to read, in this case particularly so.

We would normally write this instead:

+            rc = libxl__qmp_usb_remove(gc, domid, usbdev);
+            if (rc) goto out;

I'm assuming libxl__qmp_usb_remove returns 0 on success.  If it
doesn't you and you want to throw away the information it does return,
+            if (rc<0) goto out;
     
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel