Re: [Xen-devel] another trivial build fix

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On 17/04/13 11:03, Patrick Welche wrote:
> cp -d is a GNU extension, and only useful for links, which don't seem to
> exist in the directories being copied, so just remove said flag.
> 
> Cheers,
> 
> Patrick
> 
> 
> 0001-Don-t-use-non-portable-cp-d-flag-unnecessarily-no-li.patch
> 
> 
> From 6b274ae02e3f93709244f2af8aaa32128eca2137 Mon Sep 17 00:00:00 2001
> From: Patrick Welche <prlw1@xxxxxxxxx>
> Date: Wed, 17 Apr 2013 09:59:38 +0100
> Subject: [PATCH] Don't use non-portable cp -d flag unnecessarily (no links are
>  involved)

Again, the SoB is missing, also, could you include the description on
the email to the patch description?

Thanks, Roger.

> 
> ---
>  docs/Makefile | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/docs/Makefile b/docs/Makefile
> index fdebae8..5f319a1 100644
> --- a/docs/Makefile
> +++ b/docs/Makefile
> @@ -84,9 +84,9 @@ install: all
>       $(INSTALL_DIR) $(DESTDIR)$(DOCDIR)
>  
>       $(INSTALL_DIR) $(DESTDIR)$(MANDIR)
> -     cp -dR man1 $(DESTDIR)$(MANDIR)
> -     cp -dR man5 $(DESTDIR)$(MANDIR)
> -     [ ! -d html ] || cp -dR html $(DESTDIR)$(DOCDIR)
> +     cp -R man1 $(DESTDIR)$(MANDIR)
> +     cp -R man5 $(DESTDIR)$(MANDIR)
> +     [ ! -d html ] || cp -R html $(DESTDIR)$(DOCDIR)
>  
>  html/index.html: $(DOC_HTML) ./gen-html-index INDEX
>       perl -w -- ./gen-html-index -i INDEX html $(DOC_HTML)
> -- 1.8.2.1 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel