Re: [Xen-devel] [PATCH v4 1/2] libxl: postpone backend name resolution

[George Dunlap <george.dunlap@xxxxxxxxxxxxx>]

On 15/04/13 13:11, Ian Campbell wrote:
> On Fri, 2013-04-12 at 16:22 +0100, Daniel De Graaf wrote:
> > This adds a backend_domname field in libxl devices that contain a
> > backend_domid field, allowing either a domid or a domain name to be
> > specified in the configuration structures.  The domain name is resolved
> > into a domain ID in the _setdefault function when adding the device.
> > This change allows the backend of the block devices to be specified
> > (which previously required passing the libxl_ctx down into the block
> > device parser), and will simplify specification of backend domains in
> > other users of libxl.
> Looks good to me (some minor comments below). Given that the initial
> version of this was posted ages ago I think this should be granted a
> freeze exception. George?
1. It seems like if there are any bugs they should be caught before the 
release
2. Allowing disk backends to be specified seems like a very good feature 
for 4.3; and it seems like if there is a bug it should be caught before 
the release and fairly easy to fix.
So re the code freeze:

Acked-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel