Re: [Xen-devel] [PATCH 2/2] xen/arm: implement smp_call_function

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2013-04-16 at 11:54 +0100, Julien Grall wrote:
> On 04/16/2013 10:24 AM, Ian Campbell wrote:
> 
> > On Mon, 2013-04-15 at 17:50 +0100, Julien Grall wrote:
> >> Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>
> > 
> > This code is mostly copied from x86, perhaps we can just make it common
> > code?
> 
> 
> Indeed.
> 
> > If we are going to duplicate it then can we at least make
> > on_selected_cpus behave semantically the same. The x86 version handles
> > masks which include the local processor explicitly, since interrupts are
> > disabled I don't think we can rely on taking the interrupt locally, so
> > as it stands the code will deadlock if you pass in the current cpu?
> 
> 
> At the beginning of on_selected_cpus, we check that the interrupts are
> enabled. Even, when the SGI is sent interrupts are not disabled. So
> the code shouldn't deadlock.

Ooops, right, I read the ASSERT wrongly and/or had the previous patch
still in my head...

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel