Re: [Xen-devel] [PATCH 4/4] xen: move VCPUOP_register_vcpu_info to common code

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2013-04-09 at 15:04 +0100, Ian Campbell wrote:
> On Thu, 2013-03-21 at 18:42 +0000, Stefano Stabellini wrote:
> > Move the implementation of VCPUOP_register_vcpu_info from x86 specific
> > to commmon code.
> > 
> > Move vcpu_info_mfn from an arch specific vcpu sub-field to the common
> > vcpu struct.
> > Move the initialization of vcpu_info_mfn to common code.
> > 
> > Move unmap_vcpu_info and the call to unmap_vcpu_info at domain
> > destruction time to common code.
> > 
> > Implement map_domain_page_global and unmap_domain_page_global on ARM.
> > 
> > Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> > ---
> >  xen/arch/arm/mm.c            |   10 ++++
> >  xen/arch/x86/domain.c        |  113 
> > ------------------------------------------
> >  xen/common/domain.c          |  110 
> > ++++++++++++++++++++++++++++++++++++++++
> >  xen/include/asm-x86/domain.h |    3 -
> >  xen/include/xen/domain.h     |    3 +
> >  xen/include/xen/sched.h      |    3 +
> >  6 files changed, 126 insertions(+), 116 deletions(-)
> > 
> > diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c
> > index 972fa42..a875af5 100644
> > --- a/xen/arch/arm/mm.c
> > +++ b/xen/arch/arm/mm.c
> > @@ -125,6 +125,16 @@ void clear_fixmap(unsigned map)
> >      flush_xen_data_tlb_range_va(FIXMAP_ADDR(map), PAGE_SIZE);
> >  }
> >  
> > +void *map_domain_page_global(unsigned long mfn)
> > +{
> > +    return map_domain_page(mfn);
> 
> This isn't a global mapping, is it? IIRC map_domain_page is a vcpu local
> mapping.

I think I meant "... pcpu local mapping".

> I've presumed that most of the rest of this patch is just motion.
> 
> Given the common & x86 impact you should CC Keir + Jan too...
> 
> Ian.
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel