Re: [Xen-devel] [PATCH 3/9] arm: gic: implement IPIs using SGI mechanism

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 04/11/2013 05:17 PM, Ian Campbell wrote:

> @@ -15,17 +16,12 @@ void smp_call_function(
>      void *info,
>      int wait)
>  {
> -    /* TODO: No SMP just now, does not include self so nothing to do.
> -       cpumask_t allbutself = cpu_online_map;
> -       cpu_clear(smp_processor_id(), allbutself);
> -       on_selected_cpus(&allbutself, func, info, wait);
> -    */
> +    panic("%s not implmented\n", __func__);
>  }
> +



Panic calls smp_call_function via machine_halt function.
So, if Xen panics, you will have an infinite loop which writes "%s not
....".
For the moment, I think you should let the function in its current state.
I will try to make a patch to call a function on each CPU with ARM.

Cheers,

Julien

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel