Re: [Xen-devel] [PATCH 3 of 5 v4] tools/libxc: Implement xc_readconsolering_buffer()

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2013-03-13 at 12:52 +0000, Andrew Cooper wrote:
> +/*
> + * For both readconsolering functions, *pnr_chars is both an input and
> + * output.  As an input, it specifies the size of *buffer, and as an output
> + * indicates now many character Xen wrote into *buffer.
> + *
> + * The 'clear' parameter indicates whether Xen should clear the buffer or 
> not.

Buffer here refers to Xen's internal ring, not the char *buffer argument
to this function, right? If so the wording (at least in the context) is
a bit confusing!

The actual code looks good to me.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel