Re: [Xen-devel] [PATCH 6/9] arm: vgic: fix race in vgic_vcpu_inject_irq

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2013-03-19 at 16:10 +0000, Stefano Stabellini wrote:
> On Wed, 6 Mar 2013, Ian Campbell wrote:
> > From: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > 
> > The initial check for a still pending interrupt (!list_empty(&n->inflight))
> > needs to be covered by the vgic lock to avoid trying to insert the IRQ into 
> > the
> > inflight list simultaneously on 2 pCPUS. Expand the area covered by the lock
> > appropriately.
> > 
> > Also consolidate the unlocks on the exit path into one location.
> > 
> > Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> 
> Acked-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>

This depends on the trap WFI patch, because it turns out I made exactly
the cleanup I suggested in my review of that patch ;-)

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel