Re: [Xen-devel] [PATCH] xl: fix xl config parser

[Roger Pau Monnà <roger.pau@xxxxxxxxxx>]

On 10/04/13 15:08, Ian Campbell wrote:
> On Wed, 2013-04-10 at 08:52 +0100, Choonho Son wrote:
>> Bug: xl lexical analyzer cannot parse keyword which has .(dot) character 
>> like vif.default.script
>>
>> ref: 733b9c524dbc2bec318bfc3588ed1652455d30ec
>> Error log: /etc/xen/xl.conf:28: config parsing error near 
>> `.default.script="vif-bridge"': lexical error
> 
> Hrm. Roger, how did this ever work for you?

I have no idea what on hell I did to test this options. Dunno if somehow
I managed to not include this diff on the patches I sent. This should be
added for sure.

> 
>>
>> Signed-off-by: Choonho Son <choonho.son@xxxxxxxxx>
Acked-by: Roger Pau Monnà <roger.pau@xxxxxxxxxx>

>> ---
>>  tools/libxl/libxlu_cfg_l.l |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/tools/libxl/libxlu_cfg_l.l b/tools/libxl/libxlu_cfg_l.l
>> index efac884..d5241e1 100644
>> --- a/tools/libxl/libxlu_cfg_l.l
>> +++ b/tools/libxl/libxlu_cfg_l.l
>> @@ -52,7 +52,7 @@ void xlu__cfg_yyset_column(int  column_no, yyscan_t 
>> yyscanner);
>>  
>>  %%
>>  
>> -[a-z][_0-9a-z]*         {
>> +[a-z][._0-9a-z]*         {
>>                            yylval->string= xlu__cfgl_strdup(ctx,yytext);
>>                            GOT(IDENT);
>>                          }
> 
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel