Re: [Xen-devel] [PATCH 6/8] xen: kexec crash image when dom0 crashes

[Daniel Kiper <daniel.kiper@xxxxxxxxxx>]

On Mon, Apr 08, 2013 at 07:59:51PM +0100, David Vrabel wrote:
> From: David Vrabel <david.vrabel@xxxxxxxxxx>
>
> Signed-off-by: David Vrabel <david.vrabel@xxxxxxxxxx>
> ---
>  xen/common/shutdown.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/xen/common/shutdown.c b/xen/common/shutdown.c
> index 73a7d7b..b676a03 100644
> --- a/xen/common/shutdown.c
> +++ b/xen/common/shutdown.c
> @@ -47,6 +47,9 @@ void dom0_shutdown(u8 reason)
>      {
>          debugger_trap_immediate();
>          printk("Domain 0 crashed: ");

Maybe printk("Domain 0 crashed...\n") because kexec_crash()
does not print any message and current version looks a bit
strange i.e. it suggest that something should be printed but
something has failed... If yes then messages which could
be printed immediately after "Domain 0 crashed...\n" should
start from "..." e.g. "...rebooting...".

> +#ifdef CONFIG_KEXEC
> +        kexec_crash();
> +#endif
>          maybe_reboot();
>          break; /* not reached */
>      }

Daniel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel