Re: [Xen-devel] [PATCH 3/4] VMX: Add posted interrupt supporting

[Keir Fraser <keir.xen@xxxxxxxxx>]

On 09/04/2013 09:40, "Zhang, Yang Z" <yang.z.zhang@xxxxxxxxx> wrote:

>>> +    if ( !pi_test_and_set_on(&v->arch.hvm_vmx.pi_desc) )
>> 
>> And if it's just because you don't want to have a simple "set" only
>> operation, then the two instances should be folded, and the result
>> stored in a local variable.
> Yes. Only want to set on bit. Perhaps it is better to define a separate
> function pi_set_on() for this to make the logic more clear.

Yes!

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel