Re: [Xen-devel] [PATCH v5 1/3] arm: introduce psci_smp_ops

[Nicolas Pitre <nicolas.pitre@xxxxxxxxxx>]

On Tue, 2 Apr 2013, Stefano Stabellini wrote:

> Rename virt_smp_ops to psci_smp_ops and move them to 
> arch/arm/kernel/psci_smp.c.
> Remove mach-virt/platsmp.c, now unused.
> Compile psci_smp if CONFIG_ARM_PSCI and CONFIG_SMP.
> 
> Add a cpu_die smp_op based on psci_ops.cpu_off.
> 
> Initialize PSCI before setting smp_ops in setup_arch.
> Use psci_smp_ops if the platform doesn't provide its own smp_ops.

[...]

> @@ -766,9 +767,13 @@ void __init setup_arch(char **cmdline_p)
>       unflatten_device_tree();
>  
>       arm_dt_init_cpu_maps();
> +     psci_init();
>  #ifdef CONFIG_SMP
>       if (is_smp()) {
> -             smp_set_ops(mdesc->smp);
> +             if (mdesc->smp)
> +                     smp_set_ops(mdesc->smp);
> +             else if (psci_smp_available())
> +                     smp_set_ops(&psci_smp_ops);

Didn't we agree to do this the other way around, i.e. 

        if (psci_smp_available())
                smp_set_ops(&psci_smp_ops);
        else if (mdesc->smp)
                smp_set_ops(mdesc->smp);

?

This way you won't need the ->smp_init for Xen and that won't conflict 
with MCPM.


Nicolas

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel