Re: [Xen-devel] [PATCH 5/6] xl: export 'outstanding_pages' value from xcinfo

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Thu, Mar 28, 2013 at 04:44:22PM +0000, Ian Jackson wrote:
> Konrad Rzeszutek Wilk writes ("[PATCH 5/6] xl: export 'outstanding_pages' 
> value from xcinfo"):
> > This patch provides the value of the currently outstanding pages
> > claimed for a specific domain. This is a value that influences
> > the global outstanding claims value (See patch: "xl: 'xl info'
> > print outstanding claims if enabled") returned via
> > xc_domain_get_outstanding_pages hypercall. This domain value
> > decrements as the memory is populated for the guest and
> > eventually reaches zero.
> 
> Again this patch is fine as far as it goes but we need an update to
> the documentation with a clear and accurate definition of what these
> values are.

The original patch (v11) had this outputed to SXP but as that is in the
'do-not-touch' that part had to be removed.

And the 'libxl_dominfo' structure that comes out of this change, is only
consumed in couple of places and only certain attributes:

 - domid in 'list_domains_details'.
 - domid, vcpu_online, blocked, paused, shutdown, dying, cpu_time, ssidref in 
'list_domains'.
 - vcpu_online in 'main_cpupoolnumasplit'.
 - current_memkb, shared_memkb, domid, shutdown in 'sharing'.

Nobody seems to be using 'page_memkb', nor 'vcpu_max_id'.

I could provide the 'outstanding_memkb' value as part of 'list_domains'
but that would alter the existing format it has. I could create an 'xl claim' 
that would
be similar to 'xl list' but also include the claim information. 

But I am not sure whether there is a need for it. The 'outstanding_claims' via 
(xl info)
is good enough for it.

So your call - My thinking was that this could be in the code to be potentially
used in the future (hand-waving how), but I am also OK with just dropping this
patch and the earlier: xl/xc: export outstanding_pages value in xc_dominfo 
structure.

Let me actually drop it from the next posting - it is always nicer to have a 
slimmed
down version of patchsets.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel