[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/1]: tools: Retry blktap2 tapdisk message on interrupt.

On Mar 25, 12:40pm, Ian Jackson wrote:
} Subject: Re: [PATCH 1/1]: tools: Retry blktap2 tapdisk message on interrup

> Dr. Greg Wettstein writes ("[PATCH 1/1]: tools: Retry blktap2 tapdisk message 
> on interrupt."):
> > Re-start blktap2 IPC select call on interrupt.

> Thanks.  I have applied this patch.  But I think you should worry
> that the fix may be incomplete.  I see calls to read() as well, and
> read() can also fail with EINTR.

Yes the read/write calls on the socket are interruptible as well.  The
last patch was definitely 'scratch the itch', we have never seen a
failure on the read or write call.  I suspect catching the select call
interrupt is shielding the read/write calls from any interrupts.
Nonetheless a complete fix should address the read/write calls.

A patch immediately follows.  It went through our test harness without
any issues but since we are not proving it against a known regression
it bears running in other test environments to make sure i doesn't
trip any unexpected behavior.

> Ian.

Have a good weekend.

}-- End of excerpt from Ian Jackson

As always,
Dr. G.W. Wettstein, Ph.D.   Enjellic Systems Development, LLC.
4206 N. 19th Ave.           Specializing in information infra-structure
Fargo, ND  58102            development.
PH: 701-281-1686
FAX: 701-281-3949           EMAIL: greg@xxxxxxxxxxxx
"According to the philosopher Ly Tin Wheedle, chaos is found in greatest
 abundance wherever order is being sought.  It always defeats order,
 because it is better organized."
                                -- Terry Pratchett
                                   Interesting Times

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.