Re: [Xen-devel] [PATCH 17/18 V2]: PVH xen: PVH dom0 creation...

[Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>]

On Mon, 18 Mar 2013 13:01:23 +0000
"Jan Beulich" <JBeulich@xxxxxxxx> wrote:

>  >>> On 16.03.13 at 02:06, Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>
>  >>> wrote:
> > +static __init void copy_pvh(char *dest, char *src, int bytes)
> > +{
> > +    /* raw_copy_to_guest() -> copy_to_user_hvm -> __hvm_copy needs
> > curr 
> > +     * to point to the hvm/pvh vcpu. Hence for PVH dom0 we can't
> > use that.
> > +     * So we just use dbg_rw_mem().
> > +     */
> > +    int rem = dbg_rw_mem((dbgva_t)dest, (unsigned char *)src,
> > bytes, 0, 1, 0);
> 
> Same comment as before: This is not acceptable for a submission
> of a patch intended to be committed (i.e. non-RFC). You should
> have worked out a suitable solution to this before posting.

Well, the prev patch was RFC and I dind't hear anything on this, so 
(mis) understood this was acceptable. Ok, I will just implmement
copy_pvh() here.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel