Re: [Xen-devel] [PATCH] x86/S3: Restore broken vcpu affinity on resume

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 26.03.13 at 17:12, Ben Guthro <benjamin.guthro@xxxxxxxxxx> wrote:
> When in SYS_STATE_suspend, and going through the cpu_disable_scheduler
> path, save a copy of the current cpu affinity, and mark a flag to
> restore it later.
> 
> Later, in the resume process, when enabling nonboot cpus restore these
> affinities.
> 
> Signed-off-by: Ben Guthro <benjamin.guthro@xxxxxxxxxx>

Looks reasonable to me, minus severe formatting issues (hard
tabs being the most obvious, but not the only problem).

> --- a/xen/include/xen/sched-if.h
> +++ b/xen/include/xen/sched-if.h
> @@ -13,6 +13,9 @@
>  /* A global pointer to the initial cpupool (POOL0). */
>  extern struct cpupool *cpupool0;
>  
> +/* linked list of cpu pools */
> +extern struct cpupool *cpupool_list;
> +
>  /* cpus currently in no cpupool */
>  extern cpumask_t cpupool_free_cpus;
>  
> @@ -211,5 +214,7 @@ struct cpupool
>      (((_pool) == NULL) ? &cpupool_free_cpus : (_pool)->cpu_valid)
>  #define cpupool_online_cpumask(_pool) \
>      (((_pool) == NULL) ? &cpu_online_map : (_pool)->cpu_valid)
> +#define for_each_cpupool(ptr)    \
> +    for ((ptr) = &cpupool_list; *(ptr) != NULL; (ptr) = &((*(ptr))->next))
>  
>  #endif /* __XEN_SCHED_IF_H__ */

I don't particularly like the increase of scope for these two, but
I guess there aren't many alternatives.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel