[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] use tasklet to handle init/sipi?

On 26/03/2013 07:41, "Zhang, Yang Z" <yang.z.zhang@xxxxxxxxx> wrote:

> Keir Fraser wrote on 2013-03-26:
>> On 26/03/2013 07:17, "Zhang, Yang Z" <yang.z.zhang@xxxxxxxxx> wrote:
>>>>> Oh, I see. Well I think it is fine to have
>>>>> vlapic_schedule_init_sipi_tasklet() return X86EMUL_OKAY rather than
>>>>> X86EMUL_RETRY. We used to need to return RETRY, but the code got
>>>>> simplified and now it is actually unnecessary.
>>>>> That should make your patch a lot simpler eh? ;)
>>>> Given that you ignore the return code on the apicv call path, is there
>>>> currently a bug at all for you? Seems what is there already must work
>>>> for you?
>>> It do cause bug after we change to use seabios. For seabios, it will
>>> send INIT/SIPI to all vcpus via broadcasting. And there only one vcpu
>>> is waken up via tasklet with current logic. That's the reason why I
>>> want to wakeup all vcpus on one callback. Just change X86EMUL_RETRY to
>>> OK cannot solve the problem. still need the logic I mentioned above.
>> Ok, wait a sec, I will sort out a patch for you to try...
> Thanks. Actually, I have patch on hand and testing it now. But it's ok if you
> can provide a more better solution.

See how you like it compared with the attached patch. Attached doesn't
really make the code any more complicated, which is nice. However it is not
tested, at all. ;)

 -- Keir

> Best regards,
> Yang

Attachment: 00-vlapic-init
Description: Binary data

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.