[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] use tasklet to handle init/sipi?

On 26/03/2013 06:14, "Zhang, Yang Z" <yang.z.zhang@xxxxxxxxx> wrote:

>> You'll have t elaborate on the problem *you* are trying to solve, and why
>> such a change would do the trick. If there's good reason, I'm not against a
>> change such as this. But the code is subtle and I don't want to mess with it
>> if there are simpler solutions.
> The problem is:
> With apicv support, the apic write is trap like vmexit. We cannot fallback to
> guest to retry the instruction. So it will break current logic.

Oh, I see. Well I think it is fine to have
vlapic_schedule_init_sipi_tasklet() return X86EMUL_OKAY rather than
X86EMUL_RETRY. We used to need to return RETRY, but the code got simplified
and now it is actually unnecessary.

That should make your patch a lot simpler eh? ;)

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.